-
Notifications
You must be signed in to change notification settings - Fork 278
Fix Wan JVP image projector checkpoint compatibility - #140
Open
zjn20030811 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The JVP implementation constructed the projector with the model's non-affine
WanLayerNorm. As a result, pretrained projector normalization weights and biases were dropped during loading, changing the image-conditioning transform. The projector now mirrors the canonical Wan I2V module, so its state dictionary and numerical path are compatible with those checkpoints.Validation
All three regression tests pass.