-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Conversation
anshum4n-git
commented
Jun 20, 2025
Collaborator
Can we scope down the changes - currently a lot of styling and files are changed across. However, focussing on just the important changes
- I have a similar comment in PR SQL Decorator created for TABLE_SCHEMA creation #11 but it might be a good idea to move the prompts to a jinja2 template. That way, the dialect is just an additional variable available and jinja if blocks can be used to get the correct prompts.
- Extract schema from DB - This by itself can be a separate PR. So two different smaller PRs are easier to get merged.
- Too many new dependencies are added. Think about removing some of them and adding some of them as packages e.g. foundation-sql[postgres], foundation-sql[mysql] etc. The user (developer) should be incharge of which optional dependencies they want to include. Some of that would also need to be modified in setup.py
- It would be interesting to think of the tests as multi-db tests i.e. we should be able to run the same BasicTest across mysql, sqlite, postgres and so on.
Overall, looks good. Would just want to break it into smaller change, avoid style only changes and improve on some of the above. Looking forward to getting this merged ... 👍
rishipradeep-think41
commented
Jun 20, 2025
Author
- Another pr for Schema Extraction from the DB has been raised before this one.
Schema lookup implementation #9 - Since this pr is dependent on that one, once it is merged, this PR’s diff will only show the new changes related to dialect support.
- Will update to use jinja blocks to get the prompts instead and make dependecies optional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Summary
This PR adds support for multiple database dialects in query generation, addressing think41/foundation-sql#4.
Note:
Related Issues
Changes
Formatting
Additional Notes