-
-
Notifications
You must be signed in to change notification settings - Fork 307
fix: add missing return after reject in Promise.all for already-rejected promises#182
Open
deepview-autofix wants to merge 1 commit into
Open
fix: add missing return after reject in Promise.all for already-rejected promises #182deepview-autofix wants to merge 1 commit into
return after reject in Promise.all for already-rejected promises #182deepview-autofix wants to merge 1 commit into
Conversation
...ected promises When an already-rejected promise (state === 2) was passed to Promise.all, reject(val._value) was called but execution fell through to val.then(...), attaching an unnecessary handler to the already-rejected promise. This is inconsistent with the return pattern used for fulfilled promises (state === 1) on the preceding line. While the doResolve 'done' guard prevented incorrect behavior, the missing return wasted resources by scheduling an extra asynchronous handler invocation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-Authored-By: DeepView Autofix <276251120+deepview-autofix@users.noreply.github.com> Co-Authored-By: Nikita Skovoroda <chalkerx@gmail.com> Signed-off-by: Nikita Skovoroda <chalkerx@gmail.com>
There is no change log for this pull request yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an already-rejected promise (state === 2) was passed to Promise.all, reject(val._value) was called but execution fell through to val.then(...), attaching an unnecessary handler to the already-rejected promise. This is inconsistent with the return pattern used for fulfilled promises (state === 1) on the preceding line. While the doResolve 'done' guard prevented incorrect behavior, the missing return wasted resources by scheduling an extra asynchronous handler invocation.