Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: Implement waitFor #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eps1lon wants to merge 12 commits into testing-library:alpha
base: alpha
Choose a base branch
Loading
from eps1lon:waitfor
Open

Conversation

Copy link
Member

@eps1lon eps1lon commented Jan 14, 2023 •
edited
Loading

dcalhoun reacted with thumbs up emoji
@eps1lon eps1lon changed the title (削除) feat: Rough sketch for API (includes untested implementation) (削除ここまで) (追記) feat(waitFor): Rough sketch for API (includes untested implementation) (追記ここまで) Jan 14, 2023
Copy link

codecov-commenter commented Feb 9, 2023 •
edited by codecov bot
Loading

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@eps1lon eps1lon marked this pull request as draft February 9, 2023 11:21
@eps1lon eps1lon changed the title (削除) feat(waitFor): Rough sketch for API (includes untested implementation) (削除ここまで) (追記) feat: Implement waitFor (追記ここまで) Feb 9, 2023
@eps1lon eps1lon marked this pull request as ready for review February 9, 2023 12:13
Copy link

codesandbox-ci bot commented Oct 3, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 253fe6c:

Sandbox Source
React Configuration
react-testing-library-examples Configuration

Copy link
Member

@eps1lon Do we still want to move forwards with this effort?


export default function waitFor(
callback: () => void | Promise<void>,
options: WaitForOptions,
Copy link

@siriwatknp siriwatknp Jun 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
options: WaitForOptions,
options?: WaitForOptions,

Should options be optional? Otherwise, I get a TS error if 2nd arg is not provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver approved these changes

@nickserv nickserv Awaiting requested review from nickserv

+1 more reviewer

@siriwatknp siriwatknp siriwatknp left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support waitFor without a DOM

AltStyle によって変換されたページ (->オリジナル) /