Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

chore: optional compiler-sfc #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Copy link
Contributor

@g1eny0ung g1eny0ung commented Nov 30, 2022
edited
Loading

Signed-off-by: Yue Yang g1enyy0ung@gmail.com

Close #272.

Refer to the README, after v3.2.13, the @vue/compiler-sfc can be optional because it has already been included in the vue package.

So I mark this peer dependency as optional.

Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
Copy link
Contributor Author

@afontcu Mind taking a look at this PR when you are free?

Copy link

edumudu commented Sep 10, 2023

Just linking that this PR fixes #272

g1eny0ung and joaopslins reacted with laugh emoji

Copy link
Contributor Author

@afontcu I suddenly remembered this PR again. Almost a year has passed and I would appreciate it if you could take the time to review it.

Copy link

joaopslins commented Feb 8, 2024
edited
Loading

Was cleaning some dependencies in my project and got a warning for this unneeded peer dependency.
Would be nice to get this merged 🙇 Do we have any blockers?

Copy link
Contributor Author

Was cleaning some dependencies in my project and got a warning for this unneeded peer dependency. Would be nice to get this merged 🙇 Do we have any blockers?

I think it's just that the author doesn't bother to actively maintain the repository. 😢

Copy link
Member

@afontcu afontcu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey! Sorry this went unnoticed (again). Still taking a look at the lib from time to time, but my buffer nowadays is quite full.

Thanks for the PR, merging it now. I reckon we should apply the same change in v5 for Vue 2?

g1eny0ung and joaopslins reacted with heart emoji
@afontcu afontcu merged commit f5a3483 into testing-library:main Feb 8, 2024
Copy link

github-actions bot commented Feb 8, 2024

🎉 This PR is included in version 8.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor Author

hey! Sorry this went unnoticed (again). Still taking a look at the lib from time to time, but my buffer nowadays is quite full.

Hi @afontcu, thank you for your review! I apologize for my slightly negative comments earlier. 🙇‍♂️ I'm also a maintainer for some repos and I fully understand that we can all get a little busy and thus neglect some contributions.

Thanks for the PR, merging it now. I reckon we should apply the same change in v5 for Vue 2?

For this question, I checked the Vue 2 docs (https://v2.vuejs.org/v2/guide/migration-vue-2-7#Vue-CLI-webpack) and it says:

Upgrade vue to ^2.7.0. You can also remove vue-template-compiler from the dependencies - it is no longer needed in 2.7.*

Note: if you are using @vue/test-utils, you will need to keep vue-template-compiler in the dependencies because test utils rely on some APIs only exposed in this package.

So, as vue-testing-library relies on @vue/test-utils, I think we don't need to update the v5 branch anymore.

afontcu reacted with heart emoji

@g1eny0ung g1eny0ung deleted the chore/optional-compiler-sfc branch February 8, 2024 13:53
Copy link

That's awesome! Thanks for the quick reply and the speedy version publish 🙇

afontcu reacted with heart emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afontcu afontcu afontcu approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@vue/compiler-sfc peer dependency warning

AltStyle によって変換されたページ (->オリジナル) /