Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(types): Remove Router and Vuex dependency from types #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afontcu merged 1 commit into main from remove-dependency-types
Aug 1, 2021

Conversation

Copy link
Member

@afontcu afontcu commented Jul 30, 2021

Closes #187

I'm not entirely sure this is the best way to fix the issue, but I want to get the ball rolling.

Copy link

codecov bot commented Jul 30, 2021
edited
Loading

Codecov Report

Merging #246 (c9382eb) into main (eba2aed) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## main #246 +/- ##
=========================================
 Coverage 100.00% 100.00% 
=========================================
 Files 3 3 
 Lines 99 99 
 Branches 34 35 +1 
=========================================
 Hits 99 99 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eba2aed...c9382eb. Read the comment docs.

Copy link
Member Author

afontcu commented Aug 1, 2021

releasing this one. As stated before, if anyone comes up with a better way of handling Router/Vuex types without actually importing them, I'm all ears :)

K-Schaeffer and Panda-Program-Web reacted with thumbs up emoji

@afontcu afontcu merged commit 9d367e7 into main Aug 1, 2021
@afontcu afontcu deleted the remove-dependency-types branch August 1, 2021 17:14
Copy link

github-actions bot commented Aug 1, 2021

🎉 This PR is included in version 5.8.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Jun 8, 2022

🎉 This PR is included in version 6.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Vue testing library depends on vuex and vue-router types
1 participant

AltStyle によって変換されたページ (->オリジナル) /