Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: drop Node 10 support #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afontcu merged 1 commit into next from fix-231
Aug 1, 2021
Merged

feat: drop Node 10 support #243

afontcu merged 1 commit into next from fix-231
Aug 1, 2021

Conversation

Copy link
Member

@nickserv nickserv commented Jul 6, 2021 •
edited
Loading

Only updates engines, as CI has already been updated.

@nickserv nickserv linked an issue Jul 6, 2021 that may be closed by this pull request
Copy link

codecov bot commented Jul 6, 2021 •
edited
Loading

Codecov Report

Merging #243 (6e781d1) into next (93317d9) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 6e781d1 differs from pull request most recent head 865f930. Consider uploading reports for the commit 865f930 to get more accurate results
Impacted file tree graph 

@@ Coverage Diff @@
## next #243 +/- ##
=========================================
 Coverage 100.00% 100.00% 
=========================================
 Files 3 3 
 Lines 77 99 +22 
 Branches 27 34 +7 
=========================================
+ Hits 77 99 +22
Impacted Files Coverage Δ
src/fire-event.js 100.00% <100.00%> (ø)
src/index.js 100.00% <100.00%> (ø)
src/render.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93317d9...865f930. Read the comment docs.

Copy link
Member Author

Can you bump the major version please? Or you can put this in whatever prerelease branch you want to use if there are other breaking changes.

@nickserv nickserv added the BREAKING CHANGE This change will require a major version bump label Jul 11, 2021
@MichaelDeBoey MichaelDeBoey changed the title (削除) Drop Node 10 support (fix #231) (削除ここまで) (追記) feat: drop Node 10 support (追記ここまで) Jul 12, 2021
Copy link
Member

afontcu commented Jul 30, 2021 •
edited
Loading

Can you bump the major version please? Or you can put this in whatever prerelease branch you want to use if there are other breaking changes.

@nickmccurdy given the fact that 6.x branch is reserved for Vue 3, should we merge this one there, or release a minor version for 5.x noticing that we removed support for node 10?

Copy link
Member

MichaelDeBoey commented Jul 30, 2021 •
edited
Loading

@afontcu The base branch of this PR should be the next branch, so could your please rebase onto that branch?
afontcu reacted with thumbs up emoji

@MichaelDeBoey MichaelDeBoey changed the base branch from main to next July 30, 2021 17:43
Copy link

github-actions bot commented Aug 1, 2021

🎉 This PR is included in version 6.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

oskarols pushed a commit to oskarols/vue-testing-library that referenced this pull request Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelDeBoey MichaelDeBoey MichaelDeBoey approved these changes

@afontcu afontcu afontcu approved these changes

Assignees
No one assigned
Labels
BREAKING CHANGE This change will require a major version bump released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop Node 10 support

AltStyle によって変換されたページ (->オリジナル) /