-
-
Notifications
You must be signed in to change notification settings - Fork 71
chore: migrate from Jest to Vitest #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks! I'll take a look soon. Re the multiple configs, the one inside scripts is to build the chrome extension. You can ignore that. The site and tests can use the one in the root.
Re commit hook, it's fine if that gets disabled. But tests should be able to run on dev machines. Even on slower ones, so that developers don't rely on ci only. Remember, actions won't automatically run for first time contributors.
ambarvm
ambarvm
reviewed
May 23, 2023
ambarvm
ambarvm
previously approved these changes
May 23, 2023
This fixes the issue that caused a production build of React to be used in tests. If this causes issues with other builds, please let me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
What: migrate from Jest to Vitest
Why: Vitest is faster than Jest, compatible with most Jest APIs, and has better compatibility with Vite
How: migrate from Jest to Vitest
Checklist:
Notes:
scripts) and whether I edited the right one. Could you please explain?