Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove broken link to Firefox extension #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smeijer merged 1 commit into testing-library:develop from lx4r:feature/remove-firefox-extension-link
Mar 2, 2023
Merged

Remove broken link to Firefox extension #359

smeijer merged 1 commit into testing-library:develop from lx4r:feature/remove-firefox-extension-link
Mar 2, 2023

Conversation

Copy link
Contributor

@lx4r lx4r commented Feb 8, 2023
edited
Loading

What:

Removing the link to the Firefox extension from the page

Why:

The link is broken and the extension doesn't seem to exist under a new link either as far as I can see from the Firefox extension site and #344.

How:

Removing the link from the top bar

Checklist:

  • Tests N/A
  • Ready to be merged

Thanks in advance for the help! :)

Copy link
Contributor Author

lx4r commented Mar 2, 2023

@smeijer What can I do to move this PR forward? Thanks in advance for the help :)

Copy link
Member

smeijer commented Mar 2, 2023

It sucks that we need to, but thanks for doing so.

tryforceful reacted with confused emoji lx4r reacted with heart emoji

@smeijer smeijer merged commit 341e526 into testing-library:develop Mar 2, 2023
@lx4r lx4r deleted the feature/remove-firefox-extension-link branch March 2, 2023 20:52
smeijer added a commit that referenced this pull request Mar 2, 2023
* fix: sandbox not render another queries (#349)
* fix: sandbox not render another queries
* fixup! fix: sandbox not render another queries
* re-trigger github workflow
Co-authored-by: Breno Cota <brenogcota@gmail.com>
* chore: remove broken link to Firefox Extension (#359)
* chore: remove link to a closed roadmap (#354)
Co-authored-by: Luís Soares <lsoares@newstore.com>
* chore: remove roadmap link from specs (#361)
---------
Co-authored-by: Breno Cota <106157862+brenocota-hotmart@users.noreply.github.com>
Co-authored-by: Breno Cota <brenogcota@gmail.com>
Co-authored-by: lx4r <lx4r@users.noreply.github.com>
Co-authored-by: Luís Soares <lsoares@gmail.com>
Co-authored-by: Luís Soares <lsoares@newstore.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smeijer smeijer smeijer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants

AltStyle によって変換されたページ (->オリジナル) /