-
-
Notifications
You must be signed in to change notification settings - Fork 71
fix: improve icon button color contrast #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
smeijer
merged 1 commit into
testing-library:develop
from
tbusillo:fix/expandable-component-color-contrast
Jun 7, 2022
Merged
fix: improve icon button color contrast #345
smeijer
merged 1 commit into
testing-library:develop
from
tbusillo:fix/expandable-component-color-contrast
Jun 7, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smeijer
smeijer
approved these changes
Jun 7, 2022
Thank you @smeijer!
Deployed to testing-playground.com 🙂 thanks @tbusillo!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
What:
This PR fixes #343 by improving the color contrast between foreground and background colors used with several interactive UI elements.
Why:
Insufficient color contrast was causing the expand/collapse trigger element difficult to see for non-impaired and impaired users. This is an interactive element and its clickable target is small, so if a user cannot see the
<IconButton>, they cannot expand/collapse certain elements.How:
The default color used for
gray-500was overridden with a darker shade via extending thetailwind.config.js. In addition, the<IconButton>component was updated to make itslightanddarkvariants use the new color.Checklist:
Below artifacts show examples of the fix and new contrast ratios ("pass" for graphical objects is the relevant one):
Screen Shot 2022年05月30日 at 10 58 12 PM
Screen Shot 2022年05月30日 at 10 58 04 PM
Screen Shot 2022年05月30日 at 11 02 04 PM
Screen Shot 2022年05月30日 at 11 00 55 PM