Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add VSCode Extension to header #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Copy link
Collaborator

@aganglada aganglada commented Apr 7, 2021

What:

Added VSCode Extension link to the Header

Why:

For VSCode Extension visibility

Checklist:

  • Tests
  • Ready to be merged

@aganglada aganglada self-assigned this Apr 7, 2021
Copy link
Member

smeijer commented Apr 7, 2021

Merging this PR means that I must provide support for it, and prevent it from breaking. I'm happy to do that, but I'd suggest that we then merge the extension into this repo first. (like you've suggested before).

What do you think?

Copy link
Collaborator Author

Make sense, I will prepare another PR.

smeijer reacted with heart emoji

Copy link
Collaborator Author

Hey @smeijer, don't you think we should work on the monorepo structure before merging the extension, the extension is written in TS and maybe it will be confusing to see TS and JS dependencies all together on the same package.json.

Copy link
Member

smeijer commented Apr 9, 2021

Makes sense. What do you propose? Can you contribute to improving the structure?

Copy link
Collaborator Author

Makes sense. What do you propose? Can you contribute to improving the structure?

Sure, I will have a look at it.

Copy link
Collaborator Author

Closing this until we tackle this #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smeijer smeijer Awaiting requested review from smeijer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /