-
-
Notifications
You must be signed in to change notification settings - Fork 71
feat: make extension build scripts firefox compatible #327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make extension build scripts firefox compatible #327
Conversation
zikaari
commented
Jan 15, 2021
Are you able to run it in Firefox without having to upgrade to version 3.x.x of crx-bridge
?!
calvellido
commented
Jan 15, 2021
Tested on Firefox Developer Edition 85.0b9 (64-bit) and working like a charm, thanks!!
calvellido
commented
Jan 15, 2021
It's also working in my standard Firefox 84.0.2 (64-bit)
Are you able to run it in Firefox without having to upgrade to version 3.x.x of
crx-bridge
?!
Yes, my guess is that web-ext
is doing some sort of conversion under the hood, cause i didn't even need to change chrome.devtools
to browser.devetools
Can i upload this to firefox store and transfer to you later?
I'll take a look at this tomorrow and come back to you 😊.
Thanks for the work you've done. Much appreciated!
Thanks again! The changes are looking good! I'll try get the thing published asap.
Ok. This process was a lot simpler than for the Chrome Store, even tho Mozilla asked to upload the source code, while Google didn't do that.
Anyways, the extension has been submitted, and is "Awaiting Review". 🎉
Still waiting
Still waiting
Looks like they are verifying every new extension that come in
Yeah, bad news. I'm afraid I have to stop trying. I've submitted three versions now.
-
The first time, it was automatically rejected because I missed the question: let me know from which add-on version you've forked this listing. that they asked in the "developer hub".
-
The second time, they couldn't get it running due to some NPM issues
🚨 Build failed. @parcel/transformer-postcss: Could not resolve package "postcss" that satisfies ^8.2.1. Found 7.0.35
-
The third time, they mention the resulting code is different from the one in the final xpi.
I don't know what else to do.
I've tried to upload it on zip format and they accepted 😕
I'm gonna add you as a owner too
https://addons.mozilla.org/pt-BR/firefox/addon/testing-playground/
Thanks! You can add ...
while I go cry in a corner. Much appreciated! But their review process... Why?
I see that you've added me. Thanks! Also for submitting. I think it depends on the reviewer. You had a different reviewer, whom accepted in 2 days, no questions asked 😅.
Thanks again. Much, much, appreciated.
Hahaha, don't even i know, i just submitted and got accepted right away.
@WeslleyNasRocha , I've published a new version of the Chrome Extension, to fix a bug regarding conflicting query suggestions.
Can you publish a new version for Firefox? I'm a bit hesitant to do it myself 😅
Uh oh!
There was an error while loading. Please reload this page.
What: Adding support for Firefox extensions
Why: So people who use Firefox can use this extension
How: Adding the web-ext package, we can run and build the extension in firefox
Checklist:
It is ready to run:
build:devtools:firefox
about:debugging#/runtime/this-firefox
image
.zip
file from<project_root>/dist/
folder and click openimage
image
Peek 13-01-2021 14-53