-
Notifications
You must be signed in to change notification settings - Fork 728
Vue: Add example using props #791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Add example using props in reference to testing-library#1 in testing-library/vue-testing-library#216 (comment)
@afontcu Can you please have a look at this one? :)
Hi! Thank you for taking the time 🙌
Given the fact that the guiding principle of Testing Lib is to test components in a real environement, I'm not entirely sure we should showcase a test using stubs as a "first" example. I would keep the test simpler, and focus only on props (which was the missing bit we identified on testing-library/vue-testing-library#216 :)
We could either simplify the example, or maybe add some props to the Button example.
Again, thanks for this!
Simplify example to focus on props
Welcome @afontcu, I've reduced the example down to only focus on props. I also didn't realize my editor didn't pick up my spelling mistakes on the last commit. They showed immediately when I opened the patch. It's resolved now. Is this change okay?
@afontcu is this ready to be merged or can we close it? :)
Uh oh!
There was an error while loading. Please reload this page.
Add example using props in reference to .1 in testing-library/vue-testing-library#216 (comment)