-
Notifications
You must be signed in to change notification settings - Fork 733
docs(svelte-testing-library): simplify examples with link to STL repository #1487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(svelte-testing-library): simplify examples with link to STL repository #1487
Conversation
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@mcous since it's been a while I wanted to ask you if this is still OK to merge.
The next time feel free to assign me/ping me for a review.
Hey @timdeschryver! Yup this one is still good. Will tag you next time I need to put something up
9ae8c03
into
testing-library:main
I just got through porting the Svelte examples to v5, and I went ahead and did it in the STL repository itself so I could ensure that examples would be automatically tested (which caught a bug, which was cool).
In order to minimize the maintenance burden of the Svelte docs, this PR removes most examples from the
testing-library.comdocs in favor of linking to the STL repository for more complex examples.I kept the basic example in place, because I think it's helpful to have something here, and updated it to the same Svelte 5 example that now also lives in the STL repo.