-
Notifications
You must be signed in to change notification settings - Fork 728
Add TypeScript Examples to vue-testing-library #1463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me 👍
I'll leave this open a while longer so others can also review, otherwise i'll merge this next week.
Thanks @aburdiss!
@all-contributors please add @aburdiss for docs :)
@aburdiss already contributed before to doc
On the React Testing Library Docs, there are TypeScript examples, but these do not exist on most other pages.
I believe that it's useful for TypeScript examples to exist on other pages as well, especially examples, and even if they're extremely similar to the JavaScript examples, because this makes it more accessible to newer developers.
Disclosure: I'm newer to VueJS and TypeScript (coming from JS/React), and have been reading the docs myself to get this set up on my end, so if anyone notices better ways of handling these examples I'm not attached to the code inside.