-
Notifications
You must be signed in to change notification settings - Fork 728
Remove contradiction from documentation #1430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
remove the part that tells you to install @testing-library/dom because it is already included when using a framework wrapper
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this text can even be removed as it's kind of stating the obvious
Hi @skonky, thanks for this.
This is not true anymore for all of our framework wrappers. RTL for examples does not include DTL anymore.
I believe that this should be fixed in user-event.
@MatanBobi Cool, I will update the docs to say the opposite of what I did in the current commit :)
Uh oh!
There was an error while loading. Please reload this page.
I found something confusing in the documentation regarding testing-library-dom
Here you say that testing-library-dom should be resolved via the framework wrapper
And when you then go to the actual framework wrapper (in my case react) it states the following:
but this contradicts what is said earlier right?