-
Notifications
You must be signed in to change notification settings - Fork 728
docs: Update setup to include import statement #1153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I spent an hour trying to figure out what was wrong with my code, not realizing that user-events was an unnamed export. Please put an import statement somewhere in the docs, if not here, to save poor idiots like myself.
✅ Deploy Preview for testing-library ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@all-contributors Add @edmundsj for docs
I've put up a pull request to add @edmundsj! 🎉
I think it's odd to include the import specifically in this paragraph.
If it isn't obvious by the declarations, we should add it in intro and/or install like #1143.
(Are there really IDEs that don't display the types we deliver with the package?)
I spent an hour trying to figure out what was wrong with my code, not realizing that user-events was an unnamed export. Please put an import statement somewhere in the docs, if not here, to save poor idiots like myself.