-
Notifications
You must be signed in to change notification settings - Fork 33
test(jest): skip auto-cleanup tests in Jest #417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
The update to
esm-env@2
from sveltejs/svelte#14460 caused our auto-cleanup tests in Jest to start failing on Svelte's internal runes environment check heuristic.I'm not entirely sure of the failure mechanism, but there's a definite difference in what
esm-env
reports in Jest+JSDOM inv1
vsv2
. That being said, the auto-cleanup tests use mock functions, reseting the module cache, and faking outprocess.env
. On top of that, Jest's ESM support is still experimental. There's a high chance there are shenanigans that have nothing to do withesm-env
and/orsvelte
.I'll revisit this test when I'm ready to split the different test runners out into their own E2E-style tests with separate install environments, which (hopefully) will remove the need for the fakery and import cache resetting. For now, skipping to get CI back to green. Auto-cleanup tests continue to pass in Vitest