-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add reactStrictMode as an option to render
#1390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reactStrictMode as an option to render
#1390
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5be1d35:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flawless. Thank you! Will merge once docs are settled.
@all-contributors add @bernardobelchior for code, docs
I've put up a pull request to add @bernardobelchior! 🎉
Uh oh!
There was an error while loading. Please reload this page.
What:
Add an ability to override the global
reactStrictModeconfiguration on a per-test basis.Why:
At MUI, our tests use a small wrapper around React Testing Library and had this functionality. However, it was broken in the upgrade to React 19 since
StrictModewon't double call effects on initial mount unlessStrictModeis rendered at the root of the tree. Since we were renderingReact.StrictModeinside the component passed to thewrapperproperty, effects aren't being called twice in React 19.How:
Added a
reactStrictModetorenderOptions.Checklist:
reactStrictModeinrendertesting-library-docs#1479