Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: add render hook support for multiple arguments #1386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
imevanc wants to merge 4 commits into testing-library:main
base: main
Choose a base branch
Loading
from imevanc:pr/add-initialArgs-support

Conversation

Copy link

@imevanc imevanc commented Mar 12, 2025 •
edited
Loading

What: Add render hook support for multiple arguments

Why: renderHook only supports a single argument via initialProps, making it hard to test hooks with multiple parameters. This PR introduces initialArgs to allow passing multiple arguments directly, improving flexibility and reducing workarounds.

How:

  1. Added initialArgs support → Spreads arguments into the hook.
  2. Updated rerender → Now accepts multiple parameters.
  3. Ensured backward compatibility → initialProps remains unchanged.
  4. Throws an error if both initialProps and initialArgs are used.
  5. Added tests & updated docs → Validates behavior and documents usage.

Issue: #1350

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • TypeScript definitions updated
  • Ready to be merged

Copy link

codesandbox-ci bot commented Mar 12, 2025 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 42c12ac:

Sandbox Source
react-testing-library-examples Configuration

Copy link
Author

imevanc commented Mar 12, 2025

@eps1lon - awaiting your feedback 🧑‍💻

Copy link
Author

imevanc commented Mar 14, 2025

@danielrentz - anything to add ?

Copy link

@danielrentz danielrentz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TS typings

Copy link
Author

imevanc commented Mar 21, 2025

@Hardanish-Singh - just rebased, can you please thumb it again?

Copy link

@imevanc @Hardanish-Singh the typings are still broken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@danielrentz danielrentz danielrentz requested changes

@Hardanish-Singh Hardanish-Singh Hardanish-Singh approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /