fix: Stop restricting `container` option based on `hydrate` #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

eps1lon merged 2 commits into testing-library:main from eps1lon:simple-container

Apr 26, 2024

Merged

fix: Stop restricting `container` option based on `hydrate` #1313

eps1lon merged 2 commits into testing-library:main from eps1lon:simple-container

Apr 26, 2024

Conversation

eps1lon

Copy link

Member

@eps1lon eps1lon commented Apr 24, 2024 •

edited

Loading

Closes #1312
Closes #1311

It's really not worth it to have such extensive types just to restrict container properly. Especially because it makes composing render and renderHook so hard. And we do want to encourage wrapping render in your tests.

@codesandbox-ci CodeSandbox CI

Copy link

codesandbox-ci bot commented Apr 24, 2024 •

edited

Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f5f9f9e:

Sandbox	Source
react-testing-library-examples	Configuration

@eps1lon


 Stop restricting container option based on hydrate

2c673a7

@eps1lon eps1lon force-pushed the simple-container branch from 0538bff to cf10c6b Compare

April 24, 2024 23:40

@eps1lon


 Actually check .d.ts files

f5f9f9e

@eps1lon eps1lon force-pushed the simple-container branch from cf10c6b to f5f9f9e Compare

April 24, 2024 23:54

eps1lon

eps1lon commented

Apr 24, 2024

View reviewed changes

types/tsconfig.json

{

"extends": "../node_modules/kcd-scripts/shared-tsconfig.json",

"compilerOptions": {

"skipLibCheck": false

Copy link

Member Author

@eps1lon eps1lon Apr 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We never actually typechecked the .d.ts files before.

MatanBobi

MatanBobi reviewed

Apr 25, 2024

View reviewed changes

types/index.d.ts

export interface BaseRenderHookOptions<

/** @deprecated */

export type BaseRenderHookOptions<

Copy link

Member

@MatanBobi MatanBobi Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just so I'll understand, what's the motivation with changing this one from an interface to a type?

Copy link

Member Author

@eps1lon eps1lon Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's just an alias for RenderHookOptions whereas an interface would create a new type.

MatanBobi

MatanBobi approved these changes

Apr 25, 2024

View reviewed changes

@eps1lon eps1lon changed the title ~~(削除) Stop restricting container option based on hydrate (削除ここまで)~~ (追記) fix: Stop restricting container option based on hydrate (追記ここまで)

Apr 26, 2024