-
Notifications
You must be signed in to change notification settings - Fork 231
update react 18 #927
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update react 18 #927
Conversation
❌ Deploy Preview for react-hooks-testing-library failed.
|
Codecov Report
Merging #927 (c23edd6) into main (1213443) will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## main #927 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 15 15 Lines 245 245 Branches 34 34 ========================================= Hits 245 245
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this works for React 18, I'm not opposed to merging this even though we are deprecating this library in favour of the RTL implementation. The lack of migration path to RTL's renderHook has been and ongoing issue and blocker for many people wanting to upgrade to React 18 (for which I am very sorry).
Last I checked, the changes to the act behaviour in React 18 made all our async tests fail, so I suspect the same will happen when the CI matrix changes are made, but I'm very happy to be wrong on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to update the matrix here for it to run on CI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these could just be ^16.9.0 || ^17.0.0 || ^18.0.0 as ^18.1.0 is covered by the ^ on 18.0.0.
TannerS
commented
Dec 27, 2024
Update?
What:
Update to React 18 with Node 16
Checklist:
I'm not sure for the tests but commit passed