-
Notifications
You must be signed in to change notification settings - Fork 232
chore(docs): add waitForValueToChange shim to migration guide #924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(docs): add waitForValueToChange shim to migration guide #924
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll wait to see how you feel about the comment above, but other than that I'm happy to merge this.
Codecov Report
❗ No coverage uploaded for pull request base (
chore/migration-guide@5ba7fe9). Click here to learn what that means.
The diff coverage isn/a.
@@ Coverage Diff @@ ## chore/migration-guide #924 +/- ## ========================================================= Coverage ? 100.00% ========================================================= Files ? 15 Lines ? 246 Branches ? 34 ========================================================= Hits ? 246 Misses ? 0 Partials ? 0
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more
What: Add tips to migration guide
Why: Suggestion from comment in testing-library/react-testing-library#991 (comment)
Checklist: