Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Pr/fix typo in docs #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshuaellis merged 2 commits into testing-library:main from masious:pr/fix-typo-in-docs
Aug 7, 2021
Merged

Conversation

Copy link
Contributor

@masious masious commented Aug 7, 2021
edited
Loading

What:

The change is a typo fix.

Why:

Currently, the documentation is implying that the return value of the renderHook result is the same as current which is wrong. This PR fixes the implication.

How:

Just by changing a character in the docs!

Checklist:

  • [x ] Documentation updated
  • [x ] Ready to be merged
  • [x ] Added me to the contributors' table

Copy link

netlify bot commented Aug 7, 2021

✔️ Deploy Preview for react-hooks-testing-library ready!

🔨 Explore the source changes: f9363ab

🔍 Inspect the deploy log: https://app.netlify.com/sites/react-hooks-testing-library/deploys/610e2d38599bc8000849301b

😎 Browse the preview: https://deploy-preview-671--react-hooks-testing-library.netlify.app

Copy link
Member

@joshuaellis joshuaellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! ⭐

Copy link

codecov bot commented Aug 7, 2021
edited
Loading

Codecov Report

Merging #671 (f9363ab) into main (95d2340) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## main #671 +/- ##
=========================================
 Coverage 100.00% 100.00% 
=========================================
 Files 15 15 
 Lines 235 235 
 Branches 33 33 
=========================================
 Hits 235 235 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95d2340...f9363ab. Read the comment docs.

@joshuaellis joshuaellis merged commit 3f944e3 into testing-library:main Aug 7, 2021
Copy link

🎉 This PR is included in version 7.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaellis joshuaellis joshuaellis approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /