-
Notifications
You must be signed in to change notification settings - Fork 232
chore: drop Node 10 support #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
Merging #623 (0d85f6c) into main (882bcfe) will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## main #623 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 15 15 Lines 218 218 Branches 26 26 ========================================= Hits 218 218
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 882bcfe...0d85f6c. Read the comment docs.
24aaca3 to
da3dedb
Compare
Can somebody just rereview this and check the commit message is correct for a major bump. I always seem to mess up the order of the breaking changes, fixes and co-authors an either the wrong version gets published or the release notes get all messed up.
It should cause a breaking change release because it's in the body. I couldn't say about release notes, they're still a mystery to me.
I found this which was linked from the semantic-release docs which suggests I need 2 blank lines after the breaking change summary otherwise it will think it is the breaking change description... I'll put an extra one in to be safe 🤷♂️
BREAKING CHANGE: Node 10 is no longer supported Fixes #621 Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
da3dedb to
0d85f6c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah the breaking change system always gets me :(
Annoyingly, git is trimming the double blank line into a single new line when I commit... oh well, guess I'll just have to double check the release notes after it runs.
I didn't double line break yesterday and it worked for me if incl release notes...
Uh oh!
There was an error while loading. Please reload this page.
What:
Drop node 10 support
Why:
Fixes #621
How:
Remove node
10.13and10from node version matrix in github actions.Checklist: