Codecov Report

Merging #599 (f2464f7) into master (3fbe19d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@
## master #599 +/- ##
=========================================
 Coverage 100.00% 100.00% 
=========================================
 Files 15 15 
 Lines 219 219 
 Branches 29 29 
=========================================
 Hits 219 219 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fbe19d...f2464f7. Read the comment docs.

Would you mind explaining for someone out of the loop, why we need to make this change please? 😄

@joshuaellis

• I've added node@v10, because otherwise the tests won't run against latest v10, only against v10.13 specific
• access_token isn't required anymore by styfle/cancel-workflow-action
• Removed the specific version of actions/setup-node, so Dependabot won't bug you with every single patch update

What is the significance of node 10.13? I didn't set up the CI config and I believe it was modelled off what react-testing-library was doing at the time, but I've always been curious. Also, why do we skip node 13?

What is the significance of node 10.13?

@mpeyper 10.13 is the lowest supported Node version

Also, why do we skip node 13?

All odd versions are considered unstable, so we're only testing against latest (15) to check whether we would break on newest version or not

Sounds good.

Are you sure about the cancel action not needing a token anymore? Their docs still mention it?

@mpeyper I'm sure
https://github.com/styfle/cancel-workflow-action/releases/tag/0.7.0

I feel like I'm missing something with how the cancel action works. By reading the code it looks like access_token is a required "input", but I can see in the action logs that it's logging it found the token, but I have NFI how it found it.

I guess I don't really need to know either, but I am curious now 😅

Edit: nevermind, I found it.

Ok, all looks good. Thanks again 😃

🎉 This PR is included in version 5.1.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀