-
Notifications
You must be signed in to change notification settings - Fork 232
Feature/beta improvements #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
...extra generic parameter
Codecov Report
@@ Coverage Diff @@ ## beta #532 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 12 14 +2 Lines 189 203 +14 Branches 27 29 +2 ========================================= + Hits 189 203 +14
Continue to review full report at Codecov.
|
I'm not sure why the build has suddenly started caring about the lack of tests on src/index.ts and src/pure.ts... Probably the kcd-scripts changes?
Guess I'm looking at how we go about testing that next then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was the bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had to use require in these tests otherwise the imports have resolved before the mocking occurs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really interesting, I wasn't sure how to do this myself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
🎉 This PR is included in version 5.0.0-beta.8 🎉
The release is available on:
Your semantic-release bot 📦🚀
What:
Fixed up some things:
result.allwas introducedChecklist: