Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

fix: ReactHooksRenderer renderHook was not expecting arguments #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshuaellis merged 2 commits into beta from bugfix/beta-pure-typeerror
Jan 7, 2021

Conversation

Copy link
Member

@joshuaellis joshuaellis commented Jan 7, 2021

What:

ReactHooksRenderer was not expecting arguments due to src/pure missing those args in the renderhook function

Why:

fixes TS errors

How:

Checklist:

  • Documentation updated
  • Tests
  • Ready to be merged
  • Added myself to contributors table

@joshuaellis joshuaellis added the bug Something isn't working label Jan 7, 2021
Copy link
Member Author

I tried this in my own project and got lots or warnings about this.

Copy link

codecov bot commented Jan 7, 2021 •
edited
Loading

Codecov Report

Merging #526 (9bab184) into beta (a25993f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph 

@@ Coverage Diff @@
## beta #526 +/- ##
=========================================
 Coverage 100.00% 100.00% 
=========================================
 Files 12 12 
 Lines 186 186 
 Branches 27 27 
=========================================
 Hits 186 186
Impacted Files Coverage Δ
src/core/index.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a25993f...9bab184. Read the comment docs.

@joshuaellis joshuaellis merged commit f6096ba into beta Jan 7, 2021
@joshuaellis joshuaellis deleted the bugfix/beta-pure-typeerror branch January 7, 2021 11:00
Copy link

github-actions bot commented Jan 7, 2021

🎉 This PR is included in version 5.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpeyper mpeyper mpeyper approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /