Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Convert to TypeScript #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpeyper merged 56 commits into testing-library:beta from juhanakristian:master
Dec 15, 2020
Merged

Convert to TypeScript #520

mpeyper merged 56 commits into testing-library:beta from juhanakristian:master
Dec 15, 2020

Conversation

Copy link
Contributor

@juhanakristian juhanakristian commented Dec 14, 2020
edited
Loading

What:

Converting library to TypeScript, issue #498
Removes deprecated wait util (as per discussion in KCD Discord)
https://discord.com/channels/715220730605731931/785649901782433852/786338242101379142

Creating this PR on behalf of @tigerabrodi we and other people from KCD Discord are going to work on it as a group

Checklist:

  • Documentation updated
  • Tests
  • Ready to be merged
  • Added myself to contributors table

nobrayner and others added 30 commits December 10, 2020 09:27
this can be reverted when `pure.js` is converted to typescript
... operator
TS expecting explicit return of undefined from arrow function with type
Expected to return a value at the end of arrow function.eslintconsistent-return
resolved by passing return in catch with undefined, same behavior more explicit
- File needs better, improved typing and Refactoring for Linter Disables to be removed IF POSSIBLE
- Types and OR check should handle expected behavior
this should allow typescript to infer the type of result.current
further improvments needed to add type guards
renamed tests that didn't require code changes to the tests
- Amr, Tiger and myself worked on these commits
- Other Raid members in chat assisted
- All tests are strongly typed with minimal types
to allow for working and made sure tests types were easily usable
with types in Pure and Utils file, allow for good UX & DX
Copy link

codecov bot commented Dec 14, 2020
edited
Loading

Codecov Report

Merging #520 (a5754f2) into master (c53b56b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@
## master #520 +/- ##
=========================================
 Coverage 100.00% 100.00% 
=========================================
 Files 4 4 
 Lines 127 120 -7 
 Branches 24 22 -2 
=========================================
- Hits 127 120 -7 
Impacted Files Coverage Δ
src/index.ts 100.00% <ø> (ø)
src/asyncUtils.ts 100.00% <100.00%> (ø)
src/cleanup.ts 100.00% <100.00%> (ø)
src/pure.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c53b56b...a5754f2. Read the comment docs.

Copy link
Contributor Author

juhanakristian commented Dec 14, 2020
edited
Loading

@mpeyper The issues you listed in the previous PR have been resolved and if there isn't anything else this should be ready for merging. Let us know what you think 🙂

mpeyper reacted with thumbs up emoji

Copy link
Member

mpeyper commented Dec 14, 2020

Thanks, I'll take a look today.

tigerabrodi and JacobMGEvans reacted with heart emoji

Copy link
Member

@mpeyper mpeyper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking very close. A couple of comments here, mostly minor stuff.

@mpeyper mpeyper changed the base branch from master to beta December 15, 2020 03:18
@mpeyper mpeyper merged commit 251ea70 into testing-library:beta Dec 15, 2020
Copy link

🎉 This PR is included in version 4.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Member

mpeyper commented Jan 7, 2021

ok, it's been long enough... I'm going to release this for real now

Copy link

github-actions bot commented Jan 7, 2021

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpeyper mpeyper mpeyper left review comments

+1 more reviewer

@nobrayner nobrayner nobrayner left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /