-
Notifications
You must be signed in to change notification settings - Fork 232
chore: migrate to kcd #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate to kcd #502
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic, thank you so much!
Things I'm sad about:
- Moving tests into
src lib->dist
Both of these are 100% legit changes that align much better with the community at large but are not my personal preference (I'm not suggesting changing them just for me, just calling out my own need to let some of this stuff go).
I might have missed it, but it doesn't look like you've added yourself as as a contributor in the README? You've absolutely deserved it with this change! I'll let you determine which categories you want to include because there's tonnes that fit for this.
Other than that there's a few comments to look at, but nothing too major. Overall this is a fantastic effort! Thanks again!
I see travis-ci is failing... I'm not worried about this as the point it to replace it, but we may want to delete the .travis.yml file in PR as well?
I see travis-ci is failing... I'm not worried about this as the point it to replace it, but we may want to delete the
.travis.ymlfile in PR as well?
Yes, I have removed the travis configuration. To make semantic release works you also need to update the settings of the project and add NPM_TOKEN and GITHUB_TOKEN into secrets
To make semantic release works you also need to update the settings of the project and add
NPM_TOKENandGITHUB_TOKENinto secrets
Thanks, I'll do that before merging (which I think we're ready to do now?)
I think yes that we are ready. I hope that the pipeline will work 😄
@marcosvega91 Fun times 🔥, once this is through, we can start with the migration of render hooks to TypeScript right 😍?
Yes this is the base to make to library compatible with typescript 😄
To make semantic release works you also need to update the settings of the project and add
NPM_TOKENandGITHUB_TOKENinto secretsThanks, I'll do that before merging (which I think we're ready to do now?)
So, apparently GITHUB_TOKEN is automatically provided to actions and you aren't allowed to create secrets starting with GITHUB_.... Also, NPM_TOKEN is set up at the org level so I didn't need to create that one either.
Ok, merging this now 🤞
What:
In this PR I have migrate the codebase to use
kcd-scripts🥳I have also added these main functionalities from kcd template generator (
yo kcd-oss):I have also used prettier/linter rules from kcd, but I have disabled some rules to not change the actual code.
close #499 #501
Why:
In this way we already have typescript integration, GitHub pipeline and semantic release
How:
Checklist: