-
Notifications
You must be signed in to change notification settings - Fork 232
Fix example #47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix example #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@josepot
josepot
force-pushed
the
fix/main-example
branch
from
April 22, 2019 00:31
28e91a9 to
68cca1c
Compare
Codecov Report
Merging #47 into master will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #47 +/- ## ===================================== Coverage 100% 100% ===================================== Files 1 1 Lines 44 44 Branches 4 4 ===================================== Hits 44 44
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 7d4d3d2...68cca1c. Read the comment docs.
Nice observation.
mpeyper
added a commit
that referenced
this pull request
Apr 22, 2019
mpeyper
added a commit
that referenced
this pull request
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
I've fixed the code of the main example.
Why:
Because as I explain in this post, the custom-hook of the main example wouldn't work correctly otherwise.
How:
I just used the function overload of
setState.Checklist:
Yep