Upgrade the typings dependency and update the docs #414

@@ Coverage Diff @@
## master #414 +/- ##
=========================================
 Coverage 100.00% 100.00% 
=========================================
 Files 4 4 
 Lines 94 94 
 Branches 15 15 
=========================================
 Hits 94 94

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a873dd8...e88a323. Read the comment docs.

@erozak erozak changed the title ~~(削除) Upgrade the typings dependency and docs (削除ここまで)~~ (追記) Upgrade the typings dependency and update the docs (追記ここまで)

Jul 23, 2020

mpeyper

mpeyper reviewed

Jul 23, 2020

View reviewed changes

docs/usage/advanced-hooks.md Outdated

act(() => {

result.current.increment()

})

expect(result.current.count).toBe(2)

rerender({ step: -2 })

Copy link

Member

@mpeyper mpeyper Jul 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this is a relatively niche feature, I think we would be better off have the basic example just with a wrapper and then some text about using props with the wrapper before showing the more complex example.

Thoughts?

Copy link

Contributor Author

@erozak erozak Jul 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the revision as a new section "Providing Props". It may help to show the use case about using initialProps and the rerender method with wrapper.

erozak added 2 commits

July 23, 2020 16:15

@erozak


 Revert "Update docs"

18008d5

This reverts commit 482ee46.

@erozak


 Update the docs

e88a323

- Add new section "Providing props" under "Advanced Hooks/Context"

mpeyper

mpeyper approved these changes

Jul 23, 2020

View reviewed changes

Copy link

Member

@mpeyper mpeyper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@mpeyper mpeyper merged commit b7a2103 into testing-library:master

Jul 23, 2020

Labels

None yet

2 participants

@erozak @mpeyper

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Upgrade the typings dependency and update the docs #414

Upgrade the typings dependency and update the docs #414

Uh oh!

Conversation

@erozak erozak commented Jul 23, 2020

Uh oh!

codecov bot commented Jul 23, 2020 •

edited

Loading

Uh oh!

Codecov Report

Uh oh!

@mpeyper mpeyper Jul 23, 2020

Choose a reason for hiding this comment

Uh oh!

@erozak erozak Jul 23, 2020

Choose a reason for hiding this comment

Uh oh!

@mpeyper mpeyper left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Upgrade the typings dependency and update the docs #414

Upgrade the typings dependency and update the docs #414

Uh oh!

Conversation

@erozak erozak commented Jul 23, 2020

Uh oh!

codecov bot commented Jul 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

@mpeyper mpeyper Jul 23, 2020

Choose a reason for hiding this comment

Uh oh!

@erozak erozak Jul 23, 2020

Choose a reason for hiding this comment

Uh oh!

@mpeyper mpeyper left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Jul 23, 2020 •

edited

Loading