-
Notifications
You must be signed in to change notification settings - Fork 153
fix(react): disable no-await-sync-events by default
#984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 96.27%. Comparing base (
26d360e) to head (2c39396).
Report is 34 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@ ## main #984 +/- ## ======================================= Coverage 96.27% 96.27% ======================================= Files 46 46 Lines 2472 2472 Branches 1025 1030 +5 ======================================= Hits 2380 2380 Misses 92 92
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@eps1lon
eps1lon
force-pushed
the
disable-no-await-sync-events
branch
from
January 27, 2025 20:06
6201fe8 to
c22f128
Compare
`@testing-library/react` will require `await act()`. At that point the rule is useless. Kept for backwards compatibility.
@eps1lon
eps1lon
force-pushed
the
disable-no-await-sync-events
branch
from
January 27, 2025 20:07
c22f128 to
2c39396
Compare
1 task
@Belco90
Belco90
changed the title
(削除) [react] Disable
(追記) fix(react): disable Jan 29, 2025
testing-library/no-await-sync-events by default (削除ここまで)no-await-sync-events by default (追記ここまで)
Hi @eps1lon! Thanks for this PR and sharing context, I wasn't aware of such change.
Belco90
Belco90
approved these changes
Jan 29, 2025
It hasn't landed yet. This is just preparation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@testing-library/reactwill requireawait act(). At that point the rule is useless. Kept for backwards compatibility.Context
testing-library/react-testing-library#1214