-
Notifications
You must be signed in to change notification settings - Fork 153
fix(await-async-event): prevent adding async/await in forEach loops #1075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.42%. Comparing base (bef5e4b) to head (5d0ec0d).
Additional details and impacted files
@@ Coverage Diff @@ ## main #1075 +/- ## ======================================= Coverage 96.41% 96.42% ======================================= Files 50 50 Lines 2679 2683 +4 Branches 1099 1105 +6 ======================================= + Hits 2583 2587 +4 Misses 96 96
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
bonkevin
bonkevin
reviewed
Sep 4, 2025
const deepestCalleeIdentifier = getDeepestIdentifierNode(
functionExpression.parent
);
if (deepestCalleeIdentifier?.name === 'forEach') {
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Checks
Changes
forEachin async event method detectionContext
Fixes #843