-
Notifications
You must be signed in to change notification settings - Fork 469
Include roles from shadowDOM in Error message #999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kilmc
wants to merge
2
commits into
testing-library:main
from
kilmc:pr/enable-suggestion-for-shadow-dom-elements
Open
Include roles from shadowDOM in Error message #999
kilmc
wants to merge
2
commits into
testing-library:main
from
kilmc:pr/enable-suggestion-for-shadow-dom-elements
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2cc2867:
|
@kilmc
kilmc
changed the title
(削除) Include roles from shadowDOM in suggestion output (削除ここまで)
(追記) Include roles from shadowDOM in Error message (追記ここまで)
Aug 2, 2021
Is there anything I can do to move this along, even if it's going to be rejected?
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Adds a check which improves Error messages for folks testing Web Components using
getByRole
.Note: This PR is focused on getting a correct Error message and not a passing test. This fix will be most useful to folks using
dom-testing-library
in conjunction with the wrapper library referenced in this comment in #413.Why:
When testing Web Components the returned error is incorrect. The example below walks you through this case.
Contents of the shadowDOM for
<custom-button>
Below is a test assertion with a minor typo in it.
Before the change in this PR the error message returned is:
After the change the error becomes:
How:
Adds a check for
node.shadowRoot
inflattenDom
to ensurechildren
inside of Web Components are traversed.Checklist:
docs site N/A