-
Notifications
You must be signed in to change notification settings - Fork 467
fix: getQueriesForElement types #1354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: getQueriesForElement types #1354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good to me.
The failing build is something we'll have to look into, I will create an issue to look into this.
This change looks good to me. The failing build is something we'll have to look into, I will create an issue to look into this.
Thanks for checking @timdeschryver 👍
I noticed the CI failing and checked if it happened to other PRs and indeed it looked like some issue in every PR.
Lemme know when it gets fixed, I can merge with the main branch and push to fix if needed.
Uh oh!
There was an error while loading. Please reload this page.
What:
Fix
getQueriesForElementtype.Why:
Type definition for
getQueriesForElementdoesn't match the JS implementation.How:
Add
initialValuethird parameter to the function signature.Checklist:
docs site N/A