-
Notifications
You must be signed in to change notification settings - Fork 93
Updated testing-libary.ts #352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adresses the breaking change which comes trough angular/angular#48114
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if this also works with Angular v15.0 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it does not work with Angular v15.0 since they introduced this breaking change first at v15.1.
const colorControl = screen.getByRole('combobox', { name: /color/i }); in both testcases in the file src/app/examples/04-forms-with-material.spec.ts
Im not sure yet why, but i excluded the case to find out that this lines throws the error with Maximum call stack
@all-contributors please add @TrustNoOneElse for code
I've put up a pull request to add @TrustNoOneElse! 🎉
Addresses the breaking change which comes trough: angular/angular#48114
Fixes issue #350 .