Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Parametrize timeout in .wait_for() call#973

Open
alexberndt wants to merge 1 commit into
testcontainers:main from
alexberndt:alex/parametrize-timeout
Open

Parametrize timeout in .wait_for() call #973
alexberndt wants to merge 1 commit into
testcontainers:main from
alexberndt:alex/parametrize-timeout

Conversation

@alexberndt

@alexberndt alexberndt commented Mar 2, 2026
edited
Loading

Copy link
Copy Markdown

Parametrize the timeout time in the DockerCompose().wait_for() method, sticking to the original default of 120 seconds.

Copy link
Copy Markdown
Member

ok so better if we can add this to the base strategy class, because you can have other parameters, like interval and frequency. if you must add this now, mark it as deprecated with a note that this will be a common field in all strategies in the future. like we can even keep this parameter around indefinitely because ergonomics is important but architecturally it is out of place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /