-
Notifications
You must be signed in to change notification settings - Fork 375
fix: get_wrapped_container returns container all the time now#906
fix: get_wrapped_container returns container all the time now #906alexanderankin wants to merge 1 commit into
Conversation
alexanderankin
commented
Oct 15, 2025
ok, have to think about this one more carefully. seems like there is more to this than appears
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dumb question: can .containers.get(self.ID) return a value other than Container, e.g. None?
what if the container is not found?
alexanderankin
commented
Oct 16, 2025
via email
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We recently had a PR that added a bunch of data classes, I think I should actually be returning one of those here
fix #905