-
Notifications
You must be signed in to change notification settings - Fork 375
feat(core): Add run_containers function in utils.py to run several containers#896
Open
surister wants to merge 1 commit into
Open
feat(core): Add run_containers function in utils.py to run several containers #896surister wants to merge 1 commit into
run_containers function in utils.py to run several containers #896surister wants to merge 1 commit into
Conversation
...containers at the same time
alexanderankin
commented
Oct 7, 2025
Member
if we add this can we name it consistently with any one of the other implementations, thanks
Contributor
Author
if we add this can we name it consistently with any one of the other implementations, thanks
Hm, could you like any of the other implementations? Can't find them @alexanderankin
rhoban13
commented
Oct 13, 2025
Contributor
I'm admittedly not sure this should be part of the library, when the caller can achieve the same result explicitly with the same amount of code.
with run_containers(
PostgresContainer(network=network),
PostgresContainer(image='postgres:16', network=network),
) as containers:
c1, c2 = containers
Becomes
with contextlib.ExitStack() as stack:
c1, c2 = stack.enter_context(container) for container in (
PostgresContainer(network=network),
PostgresContainer(image='postgres:16', network=network)
)
alexanderankin
commented
Oct 15, 2025
via email
Member
...
On Mon, Oct 13, 2025 at 5:23 PM Ryan Hoban ***@***.***> wrote:
*rhoban13* left a comment (testcontainers/testcontainers-python#896)
<#896 (comment)>
I'm admittedly not sure this should be part of the library, when the
caller can achieve the same result explicitly with the same amount of code.
with run_containers(
PostgresContainer(network=network),
PostgresContainer(image='postgres:16', network=network),
) as containers:
c1, c2 = containers
Becomes
with contextlib.ExitStack() as stack:
c1, c2 = stack.enter_context(container) for container in (
PostgresContainer(network=network),
PostgresContainer(image='postgres:16', network=network)
)
—
Reply to this email directly, view it on GitHub
<#896 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACECGJEPB3G3BZVLOQQEFKT3XQJ3PAVCNFSM6AAAAACIKPW4UOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGOJZGEYDQNZSGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
alexanderankin
commented
Oct 15, 2025
via email
Member
...
On Tue, Oct 14, 2025 at 8:23 PM David Ankin ***@***.***> wrote:
https://www.javadoc.io/doc/org.testcontainers/testcontainers/1.12.1/org/testcontainers/lifecycle/Startables.html
On Mon, Oct 13, 2025 at 5:23 PM Ryan Hoban ***@***.***>
wrote:
> *rhoban13* left a comment (testcontainers/testcontainers-python#896)
> <#896 (comment)>
>
> I'm admittedly not sure this should be part of the library, when the
> caller can achieve the same result explicitly with the same amount of code.
>
> with run_containers(
> PostgresContainer(network=network),
> PostgresContainer(image='postgres:16', network=network),
> ) as containers:
> c1, c2 = containers
>
> Becomes
>
> with contextlib.ExitStack() as stack:
> c1, c2 = stack.enter_context(container) for container in (
> PostgresContainer(network=network),
> PostgresContainer(image='postgres:16', network=network)
> )
>
> —
> Reply to this email directly, view it on GitHub
> <#896 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ACECGJEPB3G3BZVLOQQEFKT3XQJ3PAVCNFSM6AAAAACIKPW4UOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGOJZGEYDQNZSGE>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
rhoban13
commented
Oct 15, 2025
Contributor
Ahhhh, I see what you're looking to achieve. I could definitely see the parallel container startup being a really useful feature. In it's current form, that's not what this PR proposes.
I suspect such an implementation and would warrant some discussion on which of python's plethora of ways to achieve parallelism makes most sense here.
@Tranquility2
Tranquility2
added
🛠️ needs more work
Need to invest more time, can be a rebase or code updates
✨ feat
labels
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This utils method runs containers on the same context manager. This ensures that the passed containers are run in order and cleaned up.
The main use case is to be able to run code after all containers have started. I need this to create CrateDB clusters.
Practical example: run containers inside a network and clean up the network (network can only be cleaned up after all containers using it are stopped)