-
Notifications
You must be signed in to change notification settings - Fork 375
Open
Conversation
Poogles
Poogles
commented
Mar 27, 2025
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I'm not too convinced on this, I think maybe using dataclasses.dataclass might be better? They offer a JSON schema schema here that could be used as a source.
Open to thoughts.
class ServiceBusContainer(DockerContainer):
"""
CockroachDB database container.
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Notice Typo
@Tranquility2
Tranquility2
changed the title
(削除) feat(modules): add Azure Service Bus Emulator module (削除ここまで)
(追記) feat(azure): add Azure Service Bus Emulator module (追記ここまで)
Apr 3, 2026
@Tranquility2
Tranquility2
added
✨ package: new
🛠️ needs more work
Need to invest more time, can be a rebase or code updates
labels
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #792.