-
Notifications
You must be signed in to change notification settings - Fork 375
Open
Conversation
Codecov Report
✅ All modified and coverable lines are covered by tests.
main@82a2e7b). Learn more about missing BASE report.
Additional details and impacted files
@@ Coverage Diff @@ ## main #735 +/- ## ======================================= Coverage ? 85.58% ======================================= Files ? 12 Lines ? 666 Branches ? 104 ======================================= Hits ? 570 Misses ? 74 Partials ? 22
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
alexanderankin
commented
Nov 14, 2024
Member
what exception does it throw? can't that exception be added to wait_container_is_ready or one of the other decorator we have and it will catch that and rerun the waiter method? this module seems to be abusing the decorators a bit here....
grieve54706
commented
Nov 18, 2024
Contributor
Author
The raised exception is when we use the Trino client to connect the container. We can't catch it.
conn = connect(
host=db.get_container_host_ip(),
port=db.get_exposed_port(db.port),
user="test",
)
cur = conn.cursor()
> cur.execute("CREATE TABLE memory.default.orders AS SELECT * from tpch.tiny.orders")
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
../.venv/lib/python3.11/site-packages/trino/dbapi.py:589: in execute
self._iterator = iter(self._query.execute())
../.venv/lib/python3.11/site-packages/trino/client.py:829: in execute
self._result.rows += self.fetch()
../.venv/lib/python3.11/site-packages/trino/client.py:849: in fetch
status = self._request.process(response)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <trino.client.TrinoRequest object at 0x115a2c210>
http_response = <Response [200]>
def process(self, http_response) -> TrinoStatus:
if not http_response.ok:
self.raise_response_error(http_response)
http_response.encoding = "utf-8"
response = http_response.json()
if "error" in response:
> raise self._process_error(response["error"], response.get("id"))
E trino.exceptions.TrinoQueryError: TrinoQueryError(type=INTERNAL_ERROR, name=GENERIC_INTERNAL_ERROR, message="nodes is empty", query_id=20241118_033536_00001_tf8kg)
../.venv/lib/python3.11/site-packages/trino/client.py:621: TrinoQueryError
Contributor
Author
The trino logs in the container
2024年11月18日 11:46:00 2024年11月18日T03:46:00.216Z INFO main io.trino.server.Server Server startup completed in 7.66s
2024年11月18日 11:46:00 2024年11月18日T03:46:00.216Z INFO main io.trino.server.Server ======== SERVER STARTED ========
2024年11月18日 11:46:00 2024年11月18日T03:46:00.844Z INFO dispatcher-query-3 io.trino.event.QueryMonitor TIMELINE: Query 20241118_034600_00000_g6qa4 :: FINISHED :: elapsed 379ms :: planning 119ms :: waiting 26ms :: scheduling 216ms :: running 32ms :: finishing 12ms :: begin 2024年11月18日T03:46:00.425Z :: end 2024年11月18日T03:46:00.804Z
2024年11月18日 11:46:01 2024年11月18日T03:46:01.070Z INFO dispatcher-query-5 io.trino.event.QueryMonitor TIMELINE: Query 20241118_034600_00001_g6qa4 :: FAILED (GENERIC_INTERNAL_ERROR) :: elapsed 197ms :: planning 197ms :: waiting 0ms :: scheduling 0ms :: running 0ms :: finishing 0ms :: begin 2024年11月18日T03:46:00.871Z :: end 2024年11月18日T03:46:01.068Z
You can see the SERVER STARTED log; the first query is FINISHED but the second is FAILED.
But the first query is SELECT 1. Maybe I can use tpch.tiny.nation and wait for it. WDYT?
deadline = time.time() + c.max_tries while time.time() < deadline: try: cur = conn.cursor() cur.execute("SELECT * FROM tpch.tiny.nation LIMIT 1") cur.fetchall() return except Exception: time.sleep(c.sleep_time) raise TimeoutError(f"Trino did not start within {c.max_tries:.3f} seconds")
grieve54706
commented
Nov 21, 2024
Contributor
Author
Hi @alexanderankin, could you recheck this PR?
@Tranquility2
Tranquility2
added
🔧 fix
🛠️ needs more work
Need to invest more time, can be a rebase or code updates
labels
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
I found the Trino container usually query failed due to
nodes is empty.I tried to execute
SELECT * FROM system.runtime.nodesandSHOW CATALOGS LIKE 'tpch'before querying to ensure that the node was active and the 'tpch' catalog was ready. It still encountered the problem. This issue may be related to a Trino discovery node problem. A similar issue was reported previously (see trinodb/trino#13388)The final solution is sleeping for a few seconds.