-
Notifications
You must be signed in to change notification settings - Fork 0
Conversation
test1card
commented
Aug 31, 2026
@codex review
Please review the exact head ea9d76e. Focus on whether the stand-local whole-file replacement is selected consistently for parsing, protected-pattern extraction, and liveness validation; whether malformed or dangling local authorities fail before persistence; and whether the fallback remains the tracked file only when the local path is lexically absent.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
i️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea9d76e351
i️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1 Badge Snapshot the selected alarm authority once
When config/alarms_v3.local.yaml is replaced while startup is in progress (for example, by an editor's atomic save), these calls read it independently: the evaluator retains the generation parsed on line 7135, protected-pattern extraction may consume a newer generation on line 7136, and liveness reads the path a third time. A dangling reference present only in the parsed generation can therefore disappear before validation, or a CRITICAL channel can be omitted from the throttle protections while still being evaluated at runtime. Read the selected bytes once and derive all three products from that immutable snapshot, as this function already does for interlocks_snapshot.
AGENTS.md reference: AGENTS.md:L20-L22
Useful? React with 👍 / 👎.
Laboratory deployment failure corrected
config/*.local.yamlis the stand-specific authority pattern, butalarms_v3.yamlwas loaded directly and had no local replacement. A laboratory with a different sensor roster therefore had to edit the tracked alarm file merely to boot, carrying permanent merge conflicts in a safety-relevant configuration.When
config/alarms_v3.local.yamlexists, this change selects it as a whole-file replacement. Otherwise the tracked base remains authoritative. The selected file is used consistently for alarm parsing, protected-pattern extraction, and complete alarm-reference liveness validation.The local file is not a bypass:
Evidence
On exact master, the four new startup controls failed: the tracked file was chosen instead of the local replacement, and malformed alarm files reached persistence without shape validation.
With this change:
git diff --checkpassed.The open pull-request queue was checked by changed file. Several older pull requests also touch
engine.py, but none implements stand-local whole-file alarm authority; this is file contention, not a duplicate subject.This pull request remains a draft until the exact-head Codex review has no findings. Full hosted CI is intentionally deferred until then.