-
Notifications
You must be signed in to change notification settings - Fork 0
fix: bind the periodic publisher to its reviewed wire path - #106
fix: bind the periodic publisher to its reviewed wire path #106test1card wants to merge 7 commits into
Conversation
test1card
commented
Aug 23, 2026
@codex review
This draft is the separate post-merge correction for pull request #103.
Please review the queue-backed publisher path, topic authority, descriptor forwarding, persistence-authority transport metadata, red-reproduction receipts, and derived governance evidence.
Two independent cold reviews returned clean on this exact candidate object. The pull request stays draft until your exact-head verdict is clean and all findings are closed.
@codex review this pull request at head babdef93719afc6ddef2c29b7eca059b2beb96d2.
Codex Review: Didn't find any major issues. Keep them coming!
Reviewed commit: babdef9371
i️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: babdef9371
i️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1 Badge Remove personal workstation data from the tracked receipt
When this tracked evidence is published, the captured PATH exposes the operator's Windows username (3fall), private home-directory layout, tool inventory, and Codex runtime paths; PYTHONPATH/TEMP and the embedded pytest output repeat those identifiers, and the second new receipt contains the same disclosure. Regenerate both receipts with usernames and machine-local paths redacted or normalized before committing them.
AGENTS.md reference: AGENTS.md:L544-L549
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P1 Badge Reproduce the producer-only false-green defect
This receipt reverts both the publisher and the consumer, and its recorded failure is the old consumer raising ValueError("invalid reading shape") on the descriptor key. That failure already occurs when a test calls _pack_reading directly, so it does not demonstrate that the strengthened queue-backed guard catches the prior coverage escape. Preserve the corrected consumer and reproduce a producer-path defect such as dropping descriptor_envelope forwarding, with the old guard green and this guard red, before using this receipt as the false-green evidence.
AGENTS.md reference: AGENTS.md:L366-L369
Useful? React with 👍 / 👎.
test1card
commented
Aug 23, 2026
Merge was deliberately stopped at head babdef9. All 19 required contexts were SUCCESS and GitHub reported CLEAN/MERGEABLE, but the exact-head blob-hash gate found two P1 review findings posted at 2026年08月23日T09:42:03Z, newer than the clean issue-comment verdict at 09:30:02Z. Therefore gate term (c), no finding newer than the clean verdict, is false. The correction will (1) normalize/redact workstation-specific paths at the red-reproduction generator boundary and regenerate both receipts, and (2) replace the false-green receipt with an executed producer-only defect: the corrected consumer remains in place while the queue-backed publisher drops descriptor-envelope forwarding, so the strengthened production-path guard must be the thing that turns red. After that, the registry digests, prevention baseline, derived pair, focused gates, two independent reviews, hosted exact-head verdict, and all five merge terms will be re-derived. No merge is attempted on this head.
Landed by the batch lander. The lane's own report and the coordinator's verification are recorded on the pull request.
test1card
commented
Aug 28, 2026
@codex review
Head under review: 8710d6ab941db2fa131d11c529922739f6fde268. Please bind your verdict to that exact SHA — the
branch moved with this correction round.
This round answers your findings on the prior head. The coordinator verified the
lane's central claim by reverting the production change and watching three
assertions redden, and read each deleted assertion against its replacement.
One thing worth your eye given what this branch touches: it changes
governance/agent_preventions.yaml, two red-reproduction receipts, and both
tools/governance_contract.py and tools/red_reproduction.py. Those are the
machinery that decides whether a recorded red is still real. Please check that
the receipts still bind the objects they claim to, and that nothing here makes a
stale receipt able to pass.
The derived pair was regenerated as the last commit and the docs gate is green at
this head. If a finding is unaddressed rather than fixed, name it rather than
treating silence as agreement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8710d6ab94
i️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2 Badge Accept schema 2 in trusted-base receipt comparison
When this new v2 receipt becomes part of the trusted base and a later guard change legitimately reruns it, compare_red_reproduction_bindings enters its moved-receipt/moved-guard path and calls _honest_candidate_receipt, but tools/ci_active_checkout_runner.py:618 still accepts only schema_version == 1. Protected active-checkout CI will therefore reject every valid rerun of this receipt before examining its bindings, making the prevention evidence impossible to update after a guard change; extend that comparison path to validate v2 before emitting v2 here.
AGENTS.md reference: AGENTS.md:L387-L390
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2 Badge Redact host paths outside the temporary worktree
When pytest reports a warning or traceback from an installed plugin or dependency, its output can contain /home/<user>/..., /Users/<user>/..., or another interpreter/site-packages path that is outside worktree; this normalizer replaces only the temporary checkout prefix, so the resulting tracked receipt can still disclose workstation identity. Fresh evidence at this head is the new generic normalizer's single-prefix replacement, while the added regression only checks the previously observed Windows strings. Redact or reject all host-specific paths before writing the receipt.
AGENTS.md reference: AGENTS.md:L544-L549
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2 Badge Align schema selection with the optional evidence modes
When callers supply --source-mutations without a false-green control, or supply a control without a source mutation, the producer permits the combination and selects schema 2 here, but _validate_red_reproduction_evidence requires every schema-2 receipt to contain both source_mutations and all control fields. The tool therefore executes the reproduction and writes a receipt that its own governance validator immediately rejects as an inexact shape; either require the two modes together up front or make the schema fields conditional.
AGENTS.md reference: AGENTS.md:L361-L369
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2 Badge Correct the summary of the executed red receipts
The bound runtime receipt selects only nine nodes, not the twelve claimed here: it omits the no-descriptor, real-socket fourth-topic, prefix-topic, and foreign-topic guards. The next claim is also inaccurate because the paired false-green receipt binds defective commit 04e7a309..., whereas only the runtime receipt binds 062a0e3b.... Consequently this tracked evidence summary overstates both the executed coverage and the common object binding; regenerate the missing executions or describe the two receipts exactly.
AGENTS.md reference: AGENTS.md:L445-L450
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2 Badge Record the environment that pytest actually received
_run_pytest receives _test_environment, which includes the actual PATH and, on Windows, COMSPEC, PATHEXT, SYSTEMROOT, and WINDIR, but every receipt replaces that mapping with this fixed four-key value. When tool resolution, plugin loading, or OS facilities affect the red result, the receipt therefore records a different environment from the one that executed and cannot support exact adjudication; normalize sensitive values while preserving the executed keys rather than dropping them.
AGENTS.md reference: AGENTS.md:L168-L170
Useful? React with 👍 / 👎.
Reason
Pull request #103 merged before its second independent review finished. That review found a real false-green guard.
The old guard called
_pack_readingdirectly. It did not drive the queue-backed publisher path that production uses.The merged commit cannot receive this correction. This pull request gives the correction a separate review object and a complete evidence trail.
Changes
Why this is the smallest correction
The change does not add a new service or wire format. It binds the existing publisher to its reviewed topic and transport contract.
The follow-up also replaces the false-green test path. It does not weaken a safety, persistence, shutdown, or sequence rule.
Local evidence
The commands used unique pytest temporary roots. No test used the shared pytest temporary directory.
Independent review
CLEANfor the exact candidate head and tree.CLEANafter an independent breadth review of the same object.This pull request opens as a draft. A hosted Codex review must return clean on the exact head before the pull request can become ready.