-
-
Notifications
You must be signed in to change notification settings - Fork 89
feat: Add optional policy_path variable used for policy definitions #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add optional policy_path variable used for policy definitions #60
Conversation
variables.tf
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Default to null is better. Please update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The default is updated to null.
... had completely omitted it if a value is null.
Thank you, @rgrund-inform !
## [4.1.0](v4.0.1...v4.1.0) (2023年12月04日) ### Features * Add optional policy_path variable used for policy definitions ([#60](#60)) ([cddcf93](cddcf93))
This PR is included in version 4.1.0 🎉
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
Description
Add optional policy_path variable used for policy definitions.
Motivation and Context
If you are using policy_path for security reasons and need to set the policy_path, you will not be able to use the terraform-aws-step-functions. With this change, the path can be configured using the policy_path variable, or leave the default "/" if the variable is omitted.
Breaking Changes
No Breaking Changes the default for policy_path remains "/".
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)I have not updated the examples as
role_pathis also not used in the examples and I suspect that it was done that way on purpose.examples/*projectspre-commit run -aon my pull request