Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat!: Added publish functionality and bump AWS provider version to v5 #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Copy link
Member

@magreenbaum magreenbaum commented Oct 1, 2023 •
edited by antonbabenko
Loading

Description

Fixes #56

Motivation and Context

#56
hashicorp/terraform-provider-aws#32176

Breaking Changes

Provider version v5.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@antonbabenko antonbabenko changed the title (削除) feat: Add publish functionality (削除ここまで) (追記) feat!: Added publish functionality and bump AWS provider version to v5 (追記ここまで) Oct 1, 2023
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great (as pretty much all of your PRs, to be honest) :)

In the future, please include the keyword "Fixes" or "Closes" in the description so that this PR automatically closes the related issue(s). I have updated description on this PR already.

magreenbaum reacted with thumbs up emoji
@antonbabenko antonbabenko merged commit 28a77d2 into terraform-aws-modules:master Oct 1, 2023
antonbabenko pushed a commit that referenced this pull request Oct 1, 2023 
## [4.0.0](v3.1.0...v4.0.0) (2023年10月01日)
### ⚠ BREAKING CHANGES
* Added publish functionality and bump AWS provider version to v5 (#57)
### Features
* Added publish functionality and bump AWS provider version to v5 ([#57](#57)) ([28a77d2](28a77d2))
Copy link
Member

This PR is included in version 4.0.0 🎉

@magreenbaum magreenbaum deleted the feat/publish_version branch October 1, 2023 13:29
Copy link

github-actions bot commented Nov 1, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko antonbabenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to publish version

AltStyle によって変換されたページ (->オリジナル) /