Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: Add output for the CloudWatch log group name and ARN created for the Step Function #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Copy link
Contributor

@dod38fr dod38fr commented Dec 1, 2022 •
edited
Loading

Description

Add cloudwatch log group name and arn in output. This log group was already created by this module. This PR only adds the output.

Motivation and Context

We need to connect the generated log group to log-metric-filter module using the name and the ARN of the log group created by this module.

Breaking Changes

None

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@dod38fr dod38fr changed the title (削除) Feat/add cloudwatch log group output (削除ここまで) (追記) feat: add cloudwatch log group output (追記ここまで) Dec 1, 2022
@dod38fr dod38fr changed the title (削除) feat: add cloudwatch log group output (削除ここまで) (追記) feat: Add cloudwatch log group output (追記ここまで) Dec 1, 2022
Copy link
Contributor Author

dod38fr commented Dec 20, 2022

Hi

@antonbabenko , is there anything preventing this PR to be merged ?

All the best

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@dod38fr dod38fr force-pushed the feat/add-cloudwatch-log-group-output branch from 263f59b to 3317944 Compare January 20, 2023 08:12
Copy link
Contributor Author

dod38fr commented Jan 20, 2023

I've reworked the history to be fully compliant with conventional commit.

Could you review this PR ?

All the best

Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

Copy link
Contributor Author

dod38fr commented Feb 20, 2023

Any news ?

@dod38fr dod38fr force-pushed the feat/add-cloudwatch-log-group-output branch from 3317944 to 1337c85 Compare February 20, 2023 09:42
@dod38fr dod38fr changed the title (削除) feat: Add cloudwatch log group output (削除ここまで) (追記) feat: Add output for the ARN of the CloudWatch log group created for the Step Function (追記ここまで) Mar 6, 2023
@dod38fr dod38fr changed the title (削除) feat: Add output for the ARN of the CloudWatch log group created for the Step Function (削除ここまで) (追記) feat: Add output for the CloudWatch log group name and ARN created for the Step Function (追記ここまで) Mar 6, 2023
Copy link

github-actions bot commented Apr 6, 2023

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

Copy link
Contributor Author

dod38fr commented Apr 7, 2023

Any news ?
antonbabenko reacted with thumbs up emoji

@antonbabenko antonbabenko merged commit 62afe34 into terraform-aws-modules:master Apr 7, 2023
antonbabenko pushed a commit that referenced this pull request Apr 7, 2023 
## [2.8.0](v2.7.3...v2.8.0) (2023年04月07日)
### Features
* Add output for the CloudWatch log group name and ARN created for the Step Function ([#45](#45)) ([62afe34](62afe34))
Copy link
Member

This PR is included in version 2.8.0 🎉
dod38fr reacted with laugh emoji

Copy link

github-actions bot commented May 8, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /