-
-
Notifications
You must be signed in to change notification settings - Fork 89
fix: Move default resources for events for AWS Batch service integration #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Move default resources for events for AWS Batch service integration #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch!
### [2.7.2](v2.7.1...v2.7.2) (2022年11月02日) ### Bug Fixes * Move default resources for events for AWS Batch service integration ([#44](#44)) ([bb2186b](bb2186b))
This PR is included in version 2.7.2 🎉
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
Description
default_resources
for AWS Batch service integration (events
) are not working correctly as inlocals.tf
they belong to the outer scope
batch_Sync
whereas they should belong to the nestedevents
field.My workaround for the problem was:
Which works, but it would be nice to fix and hide the events policy as for other services it works flawlessly. Thus the MR.
Motivation / Context / Breaking Changes
No regression is being introduced as they field is not used currently (as it lies outside of the keys context either way):
image
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull requestTested with
init
andplan
, onmaster
plan does not work correctly:image
After the changes everything is fine, 2 more resources as expected:
image
image