-
-
Notifications
You must be signed in to change notification settings - Fork 89
feat: Enabled tags for IAM policies #38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enabled tags for IAM policies #38
Conversation
Hi @antonbabenko . Hope you are doing well. Please can you review the above MR. This is to enable tags. It is to address the issue raised here #32
Thank you. :) !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the formatting (alignment) - failing GH Actions.
There is no need to make changes in CHANGELOG.md because it will be overwritten during the release.
Hi @antonbabenko . Thank you for the update. It has been formatted. The changelog update was removed :)
## [2.7.0](v2.6.0...v2.7.0) (2022年04月13日) ### Features * Enabled tags for IAM policies ([#38](#38)) ([f9d3a89](f9d3a89))
This PR is included in version 2.7.0 🎉
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.
Description
Enablement of tags for:
The ''aws_iam_policy" resource with 'service' resource name
The ''aws_iam_policy" resource with 'additional_json' resource name
The ''aws_iam_policy" resource with 'additional_jsons' resource name
The ''aws_iam_policy" resource with 'additional_inline' resource name
The ''aws_iam_policy" resource with 'logs' resource name
Motivation and Context
When we began using the repo, we found that some of the resources are yet to be tag enabled. Hence when our internal projects were calling this repo, our custom tags were not being added in AWS.
Breaking Changes
No
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)