Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat: Added default resources for events permissions #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Copy link
Contributor

@Octogonapus Octogonapus commented Mar 11, 2022 •
edited
Loading

Description

This PR adds the relevant default_resources to each events block inside the aws_service_policies such that users can write events = true for services that require these permissions.

Motivation and Context

Fixes #33.

Breaking Changes

No breaking changes have been introduced. The default_resources for eventbridge could (should) be reduced in scope, but that would be a breaking change.

How Has This Been Tested?

I have tested the step functions default_resources, as that is what I use in my projects, but I don't have a way to test the other default_resources right now.

@Octogonapus Octogonapus changed the title (削除) Add default resources for execution rules (削除ここまで) (追記) feat: Add default resources for execution rules (追記ここまで) Mar 11, 2022
@Octogonapus Octogonapus changed the title (削除) feat: Add default resources for execution rules (削除ここまで) (追記) feat: Add default resources for events permissions (追記ここまで) Mar 11, 2022
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

Copy link
Contributor Author

This should be RTM if a maintainer has time to review it.

@antonbabenko antonbabenko changed the title (削除) feat: Add default resources for events permissions (削除ここまで) (追記) feat: Added default resources for events permissions (追記ここまで) Apr 11, 2022
@antonbabenko antonbabenko merged commit 698e4c1 into terraform-aws-modules:master Apr 11, 2022
Copy link
Member

Thanks @Octogonapus for the contribution!

antonbabenko pushed a commit that referenced this pull request Apr 11, 2022 
## [2.6.0](v2.5.2...v2.6.0) (2022年04月11日)
### Features
* Added default resources for events permissions ([#34](#34)) ([698e4c1](698e4c1))
Copy link
Member

This PR is included in version 2.6.0 🎉

@Octogonapus Octogonapus deleted the add_default_resources_for_execution_rules branch April 11, 2022 12:56
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it easier to use service integrations that require events permissions

AltStyle によって変換されたページ (->オリジナル) /